Update and Fix SIK_circuit04_multipleLEDs.ino #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Change description of PingPong() on line 47 to make it more clear what the function is doing. -Removed code between lines 105-110 oneOnAtATime() since it was exactly the same as the PingPong(). The way the function written did not seem work as intended. -Change description on line 49 and 145 for marquee(). -Changed syntax for incrementing and decrementing [ https://www.arduino.cc/en/reference/increment ] because the code was not working as expected where code uses: index = index ++ and index = index-- This currently returns the old index value and saves it in index. If it was just index++ of index--, it would have been fine since index value updates when incrementing/decrementing. -We will need to go through the tutorials for a few SIKs and update the code.
Update and Fix SIK_circuit04_multipleLEDs.ino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Change description of PingPong() on line 47 to make it more clear what the function is doing.
-Removed code between lines 105-110 oneOnAtATime() since it was exactly the same as the PingPong(). The way the function written did not seem work as intended.
-Change description on line 49 and 145 for marquee().
-Changed syntax for incrementing and decrementing [ https://www.arduino.cc/en/reference/increment ] because the code was not working as expected where code uses:
and
This currently returns the old index value and saves it in index. If it was just index++ of index--, it would have been fine since index value updates when incrementing/decrementing.
-We will need to go through the tutorials for a few SIKs and update the code.