-
-
Notifications
You must be signed in to change notification settings - Fork 6
Create test for disabling schema autocompletion #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: karan-palan <[email protected]>
vscode/src/extension.ts
Outdated
| const config = vscode.workspace.getConfiguration('sourcemeta-studio'); | ||
| if (config.get('disableBuiltInValidation', true)) { | ||
| vscode.workspace.getConfiguration('json').update('validate.enable', false, vscode.ConfigurationTarget.Workspace); | ||
| // Use Global config if no workspace is open, otherwise use Workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added as tests fail when no workspace is opened
🤖 Augment PR SummarySummary: Adds a VS Code integration test to ensure Sourcemeta Studio disables VS Code’s built-in JSON validation (fixes #18). Changes:
Technical Notes: The JSON validation toggle now targets 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: karan-palan <[email protected]>
| } | ||
|
|
||
| const fixtureDir = path.join(__dirname, '..', '..', '..', 'test', 'vscode', 'fixtures'); | ||
| const schemaPath = path.join(fixtureDir, 'invalid-metaschema.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uses a schema with metaschema errors that VS Code would catch if validation is enabled
|
Awesome! |
fixes #18