-
-
Notifications
You must be signed in to change notification settings - Fork 6
Simplify CLI integration by using the new spawn function instead of manually managing CLI paths and spawning processes.
#131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: karan-palan <[email protected]>
🤖 Augment PR SummarySummary: Refactors the VS Code extension’s CLI integration to use the new Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review completed. No suggestions at this time.
Comment augment review to trigger a new review at any time.
Signed-off-by: karan-palan <[email protected]>
| $(INSTALL) -m 0664 vscode/package.json build/vscode/package.json | ||
| $(JQ) '.main = "./extension.js"' vscode/package.json > build/vscode/package.json | ||
| $(INSTALL) -m 0664 vscode/package-lock.json build/vscode/package-lock.json | ||
| cd build/vscode && $(NPM) ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we need this? I think the package step will do this already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI fails without it. The extension runs from build/vscode/extension.js which requires @sourcemeta/jsonschema from node_modules. We marked it as external in esbuild (as it is 28mb), so build/vscode/node_modules must exist before tests run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I guess that's fine. Maybe someday we revamp this with CMake 😅
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
fixes #130