Skip to content

Conversation

@Karan-Palan
Copy link
Collaborator

@Karan-Palan Karan-Palan commented Dec 22, 2025

fixes #130

@augmentcode
Copy link

augmentcode bot commented Dec 22, 2025

🤖 Augment PR Summary

Summary: Refactors the VS Code extension’s CLI integration to use the new @sourcemeta/jsonschema spawn() helper instead of manually resolving the CLI script path and spawning Node.

Changes:

  • Simplified CommandExecutor to call spawn(args) and map its stdout/stderr + exit code into CommandResult.
  • Updated extension activation to construct CommandExecutor without extensionPath.
  • Adjusted the VS Code extension test to assert only on error-severity diagnostics for HTTP $ref cases.
  • Updated VS Code build/deps: externalized @sourcemeta/jsonschema in esbuild and bumped the dependency to ^13.3.0.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Signed-off-by: karan-palan <[email protected]>
$(INSTALL) -m 0664 vscode/package.json build/vscode/package.json
$(JQ) '.main = "./extension.js"' vscode/package.json > build/vscode/package.json
$(INSTALL) -m 0664 vscode/package-lock.json build/vscode/package-lock.json
cd build/vscode && $(NPM) ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we need this? I think the package step will do this already

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fails without it. The extension runs from build/vscode/extension.js which requires @sourcemeta/jsonschema from node_modules. We marked it as external in esbuild (as it is 28mb), so build/vscode/node_modules must exist before tests run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess that's fine. Maybe someday we revamp this with CMake 😅

Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
Signed-off-by: karan-palan <[email protected]>
@jviotti jviotti merged commit faec85d into main Dec 23, 2025
6 of 7 checks passed
@jviotti jviotti deleted the 130 branch December 23, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify CommandExecutor

3 participants