Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM Api #9722

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

LLM Api #9722

wants to merge 42 commits into from

Conversation

EItanya
Copy link
Member

@EItanya EItanya commented Jul 3, 2024

This PR introduces the new API for the LLM focused functionality in Gloo Gateway

@EItanya EItanya requested a review from a team as a code owner July 3, 2024 20:22
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jul 3, 2024
@@ -293,6 +293,9 @@ message TransformationTemplate {
// If you want to nest elements inside the body, use dot separator in the
// extractor name.
MergeExtractorsToBody merge_extractors_to_body = 6;
// A list of keys to merge into the JSON body. If the key already exists in
// the body it will be overwritten.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is keys referring to here in the context of a request/response body?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't user-facing config, internal to our filter.

projects/gloo/api/v1/enterprise/options/ai/ai.proto Outdated Show resolved Hide resolved
}


message Redis {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment as Postgres, perhaps nest this under semantic_cache.datastore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the use-case here is probably only for semantic caching, I will move it

Copy link

github-actions bot commented Jul 3, 2024

Visit the preview URL for this PR (updated for commit cae11ac):

https://gloo-edge--pr9722-eitanya-ai-gateway-l1jpyx94.web.app

(expires Tue, 23 Jul 2024 13:43:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

shashankram
shashankram previously approved these changes Jul 15, 2024
@solo-changelog-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants