-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM Api #9722
base: main
Are you sure you want to change the base?
LLM Api #9722
Conversation
@@ -293,6 +293,9 @@ message TransformationTemplate { | |||
// If you want to nest elements inside the body, use dot separator in the | |||
// extractor name. | |||
MergeExtractorsToBody merge_extractors_to_body = 6; | |||
// A list of keys to merge into the JSON body. If the key already exists in | |||
// the body it will be overwritten. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is keys
referring to here in the context of a request/response body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't user-facing config, internal to our filter.
} | ||
|
||
|
||
message Redis { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment as Postgres, perhaps nest this under semantic_cache.datastore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the use-case here is probably only for semantic caching, I will move it
Visit the preview URL for this PR (updated for commit cae11ac): https://gloo-edge--pr9722-eitanya-ai-gateway-l1jpyx94.web.app (expires Tue, 23 Jul 2024 13:43:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
…into eitanya/ai-gateway
…into eitanya/ai-gateway
…into eitanya/ai-gateway
Issues linked to changelog: |
This PR introduces the new API for the LLM focused functionality in Gloo Gateway