prevent multiple entries of same methode in FastRouteDispatcher#3271
Merged
l0gicgate merged 1 commit intoslimphp:4.xfrom Jul 23, 2023
Merged
Conversation
l0gicgate
approved these changes
Jul 23, 2023
Member
|
Thank you for this contribution @papparazzo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you create two routes, one with a static path and the other one with a placeholder
and call "getAllowedMethods" from Slim/Routing/FastRouteDispatcher.php afterwards, the same method is returned twice, because one route is set in staticRouteMap while the other one is set in variableRouteData.
Please see example below for further information
composer.json:
public/index.php:
Output: