Skip to content

Conversation

@t0mmy742
Copy link
Contributor

@t0mmy742 t0mmy742 commented Aug 2, 2021

SlimPHP is easily compatible with psr/log ^2.0 and ^3.0.
String cast has be added to \Slim\Logger class since \error_log function takes a string as parameter.

To complete: Should we remove PHP 7.2 support ? Some dependencies of composer.json could not be updated to their higher version since most of them remove PHP 7.2 support. This PHPversion is EOL for 8 months (30 Nov 2020).
If needed, I can make another PR for this.

Closes #3096
Closes #3097
Closes #3098

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 249b0b3 on t0mmy742:allow_updated_psr_log into 7e7c9db on slimphp:4.x.

@l0gicgate
Copy link
Member

I'm in favor of removing PHP 7.2 support @t0mmy742

Also thank you for this contribution.

@l0gicgate l0gicgate added this to the 4.9.0 milestone Aug 4, 2021
@l0gicgate l0gicgate merged commit 4b3818d into slimphp:4.x Aug 4, 2021
@t0mmy742 t0mmy742 deleted the allow_updated_psr_log branch August 4, 2021 16:11
@l0gicgate l0gicgate mentioned this pull request Oct 5, 2021
chriscct7 pushed a commit to awesomemotive/aioseo-slim-v3-php-8.1 that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants