Add initial MAINTAINERS document#2572
Merged
l0gicgate merged 1 commit intoslimphp:3.xfrom Jan 23, 2019
akrabat:maintainers-doc
Merged
Add initial MAINTAINERS document#2572l0gicgate merged 1 commit intoslimphp:3.xfrom akrabat:maintainers-doc
l0gicgate merged 1 commit intoslimphp:3.xfrom
akrabat:maintainers-doc
Conversation
l0gicgate
approved these changes
Jan 23, 2019
johnrhunt
reviewed
Jan 23, 2019
|
|
||
| ## We don't merge our own PRs | ||
|
|
||
| Our code is better if more than one set of eyes looks at it. Therefore we do not merge our own pull requests unless there is an exceptional circumstance. This helps to spot errors in the patch and also enables us to share information about the project around the maintainer team. |
There was a problem hiding this comment.
This helps us spot errors in the patch and also enables us to share information about the project with the maintainers team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.