Allow SameSite flag to be used in cookies

[sg3s]

This should resolve #2387 if accepted.

(btw, I think you should use trailing commas for array lists, but of course didn't add those to stay inline with the rest)

[coveralls]

Coverage increased (+0.005%) to 97.078% when pulling fa35755 on sg3s:allow-samesite-in-cookie into 289fd6c on slimphp:3.x.

[sg3s]

I do not know why Travis failed on hhvm, not familiar with either and the errors look vague to me.

If it is something I can fix I would love to hear suggestions.

[akrabat]

This looks great. Would you mind raising a PR in https://github.com/slimphp/Slim-Website to document it?

Also, Slim 4.x will use https://github.com/slimphp/Slim-Http, so could you port this PR to that respository too, so we have it for the future?

[akrabat]

If you rebase against 3.x and then force push to your branch on your clone, then Travis should pass now.

[sg3s]

Thank you for the feedback.

I can rebase & push quite easily, but looking back on my code I see that I have mistaken 'non-strict comparison' for 'case-insensitive comparison'. Which is a dumb mistake. To compare I need to normalize the input properly.

1. Use strtolower or ucfirst (or something else?) on the input? (the used case doesn't actually matter for setting the cookie flags)
2. Want a specific test for that case?

Cookies don't seem to be documented in v3 (I'm guessing the class shouldn't be present, it is mentioned in the v3 upgrade guide that it was removed) so where should I put this?

I will cherry-pick the patch to Slim-Http/v4 after figuring out the above.

[akrabat]

1. Use strtolower or ucfirst (or something else?) on the input? (the used case doesn't actually matter for setting the cookie flags)

Use strtolower() or stripos().

2. Want a specific test for that case?

Yes.

[akrabat]

@sg3s are you likely to be able to work on this?

[sg3s]

@akrabat My apologies, I think I've missed the previous comment and I have been quite busy so I wasn't checking up on it either.

Updated, added test & rebased. I think I've done that correctly, feedback is welcome :)

[akrabat]

Thanks @sg3s! Fancy putting the same patch into https://github.com/slimphp/Slim-Http ?