-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Docs: Custom steps documentation #1457
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1457 +/- ##
=========================================
Coverage 73.03% 73.03%
- Complexity 4378 4379 +1
=========================================
Files 475 475
Lines 14243 14243
Branches 1447 1447
=========================================
+ Hits 10402 10403 +1
+ Misses 2987 2986 -1
Partials 854 854 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💯 thanks for working on this
Left a few small comments, once resolved we can merge
docs/content/guides/custom-steps.md
Outdated
} | ||
``` | ||
|
||
Once your custom step is defined in your app's manifest and implemented in code, it is discoverable in Workflow Builder when you **Add Step** and search for the name of your app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once your custom step is defined in your app's manifest and implemented in code, it is discoverable in Workflow Builder when you **Add Step** and search for the name of your app. | |
Once your custom step is defined in your app's manifest and implemented in code, it is discoverable in Workflow Builder when you **Add Step** and search for the title of your step or name of your app. |
docs/content/guides/custom-steps.md
Outdated
app.function("sample_function", (req, ctx) -> { | ||
app.executorService().submit(() -> { | ||
try { | ||
var userId = req.getEvent().getInputs().get("user_id").asString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every other code snippet in these docs use the proper type rather then var
var userId = req.getEvent().getInputs().get("user_id").asString(); | |
String userId = req.getEvent().getInputs().get("user_id").asString(); |
docs/content/guides/custom-steps.md
Outdated
app.executorService().submit(() -> { | ||
try { | ||
var userId = req.getEvent().getInputs().get("user_id").asString(); | ||
var response = ctx.client().chatPostMessage(r -> r |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var response = ctx.client().chatPostMessage(r -> r | |
ChatPostMessageResponse response = ctx.client().chatPostMessage(r -> r |
docs/content/guides/custom-steps.md
Outdated
.channel(userId) // sending a DM | ||
.text("Hi! Thank you for submitting the request! We'll let you know once the processing completes.") | ||
); | ||
var outputs = new HashMap<String, Object>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var outputs = new HashMap<String, Object>(); | |
Map<String, Object> outputs = new HashMap<String, Object>(); |
Added a documentation page about custom steps.
Category (place an
x
in each of the[ ]
)Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.