Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis installation and oauth state services #1432

Closed
wants to merge 4 commits into from

Conversation

bruceadowns
Copy link

Create a new Installation service and OAuth State service using Redis (or ValKey) storage.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@bruceadowns bruceadowns marked this pull request as ready for review February 2, 2025 01:34
@seratch
Copy link
Contributor

seratch commented Feb 3, 2025

Hi @bruceadowns, thank you so much for sending this pull request! However, our team currently does not have plans to add further built-in implementations to the package due to our team's capacity and priorities. If you plan to use this Redis implementation for your projects, please include it within your project or release it as your own open-source library.

Thanks again for taking the time to make this PR! For future collaborations, creating an issue to suggest a new feature before working on code changes would make the process smoother. We sometimes have to say no to some external contributions, even when they're great. It'd be appreciated if you could understand this.

@seratch seratch closed this Feb 3, 2025
@bruceadowns
Copy link
Author

Thank you for reviewing @seratch, I will incorporate this functionality directly in my project for now. For the record the redis/valkey cache solution works great, with a much better latency than S3, which is important considering how often the middleware calls findBot().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants