Skip to content

Conversation

@rhendrickson-sc
Copy link
Contributor

Ticket: #152

Issue

A file had CR LF line endings instead of the expected LF line endings.

Solution

  1. Ran find -type f -exec grep -Iq . {} \; -and -exec grep -Il $'\r' {} + to discover which files were affected.
  2. Ran dos2unix ./docs/authorization.md to convert the line endings on the file.
  3. Re-ran find -type f -exec grep -Iq . {} \; -and -exec grep -Il $'\r' {} + to verify line endings were fixed.

Image showing the steps done:

image

Impact

Should have no impact other than stopping IDEs from warning people that they're committing a file with CR LF line endings.

Usage Changes

No usage changed.

Considerations

Could always set up a GitHub Action pipeline that runs test for linting, formatting, and/or line endings?

Testing

Hard to write a test for a line ending change, but I ran lando unit and lando sniff regardless, nothing I did affected the outputs of these commands, as it was the same before and after:

image

@rhendrickson-sc rhendrickson-sc added low priority We might not get to this refactor Changing the code w/o affecting behavior labels Dec 16, 2024
@rhendrickson-sc rhendrickson-sc self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

low priority We might not get to this refactor Changing the code w/o affecting behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants