Skip to content

Maintenance/upgrade js dependencies #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tmobaird
Copy link
Contributor

@tmobaird tmobaird commented Apr 9, 2017

References #382.

@justin808 here's the second PR for updating the dependencies. Note: This PR does NOT include the update of the react libraries. Apparently the new react, react-router, react-dom versions that were released added a lot of breaking changes. An example is removing PropTypes from the react library and adding it to it's own npm module. I'm not sure the amount of updates this will cause, but I figured it was best to leave out of this PR for size.

Any suggestions about how to tackle this?

This PR includes:

  • Updating the node version in the .nvmrc
  • Adding yarn to engines in package.json's
  • Updating JS dependencies

Also I noticed that npm was still included in the engines section of the package.json's. Any idea if this can be removed?

Feel free to let me know any other suggestions you have!


This change is Reviewable

@justin808
Copy link
Member

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

@tmobaird I think we should try to upgrade. The codemod should make this painless.

@justin808 justin808 merged commit 8a28b19 into shakacode:master Apr 9, 2017
@justin808
Copy link
Member

@tmobaird I figure it's best if we do the 15.5 one in its own PR.

@tmobaird
Copy link
Contributor Author

tmobaird commented Apr 9, 2017

@justin808 awesome, that sounds good. I'll try to knock that out today! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants