fix: bump parking_lot to 0.12 in order to not create wasm export#254
Merged
bors-servo merged 2 commits intoservo:masterfrom Feb 23, 2022
Merged
fix: bump parking_lot to 0.12 in order to not create wasm export#254bors-servo merged 2 commits intoservo:masterfrom
bors-servo merged 2 commits intoservo:masterfrom
Conversation
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit cbd1dc3 has been approved by |
Contributor
bors-servo
added a commit
that referenced
this pull request
Feb 14, 2022
fix: bump parking_lot to 0.12 in order to not create wasm export parking_lot 0.11 was using parking_lot_core 0.8 which was creating a wasm export when targeting wasm: Amanieu/parking_lot#269 This bumps to parking_lot 0.12, which uses parking_lot_core 0.9 which doesn't have the issue where it creates the wasm export.
Contributor
|
💔 Test failed - checks-github |
Contributor
Author
|
Failed because of use of Current rust version is 1.58.1, CI is on 1.40. Is it an issue to upgrade to 1.49? |
Contributor
Author
|
I'm guessing it doesn't work when I do it, but worth a try 😄 @bors-servo r+ |
Contributor
|
@dsherret: 🔑 Insufficient privileges: Not in reviewers |
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit 6c0f825 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-github |
Contributor
|
Is there a plan to publish a new version for this change? The version on crates.io is still using parking_lot 0.11. |
Merged
bors-servo
added a commit
that referenced
this pull request
Mar 27, 2022
0.8.4 Would like to get #254
Member
|
Published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parking_lot 0.11 was using parking_lot_core 0.8 which was creating a wasm export when targeting wasm: Amanieu/parking_lot#269
This bumps to parking_lot 0.12, which uses parking_lot_core 0.9 which doesn't have the issue where it creates the wasm export.