libservo: Remove ServoDelegate::notify_animating_changed
#40886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is dead code servo#40799, as it is never called. Remove the delegate call and the entire `ServoShellServoDelegate` as the only thing that it was doing was printing top-level errors which only happen when something goes very wrong. It's quite likely that backtraces printed earlier will be more useful. Signed-off-by: Martin Robinson <[email protected]>
mukilan
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is dead code #40799, as it is never called. Remove the delegate
call and the entire
ServoShellServoDelegateas the only thing that itwas doing was printing top-level errors which only happen when something
goes very wrong. It's quite likely that backtraces printed earlier
will be more useful.
Testing: This just removes dead code, so should be covered by existing tests.