Skip to content

修复getFaviconFromDomain的并发问题#597

Merged
CodFrm merged 1 commit intoscriptscat:mainfrom
cyfung1031:修Bug
Aug 2, 2025

Hidden character warning

The head ref may contain hidden characters: "\u4feeBug"
Merged

修复getFaviconFromDomain的并发问题#597
CodFrm merged 1 commit intoscriptscat:mainfrom
cyfung1031:修Bug

Conversation

@cyfung1031
Copy link
Collaborator

No description provided.

@CodFrm
Copy link
Member

CodFrm commented Aug 2, 2025

为什么是储存的Promise呢?直接内部处理了,返回似乎也没有问题?

@cyfung1031
Copy link
Collaborator Author

cyfung1031 commented Aug 2, 2025

为什么是储存的Promise呢?直接内部处理了,返回似乎也没有问题?

getFaviconFromDomain("https://google.com")

getFaviconFromDomain("https://yahoo.com")

getFaviconFromDomain("https://google.com")

getFaviconFromDomain("https://yahoo.com")

你的修改會是fetch四次。(等到有結果才cache)
我這個是fetch兩次 (不用等結果)

@CodFrm CodFrm merged commit 1872fe1 into scriptscat:main Aug 2, 2025
3 checks passed
@cyfung1031 cyfung1031 changed the title 修Bug 修复getFaviconFromDomain的并发问题 Aug 3, 2025
@cyfung1031 cyfung1031 deleted the 修Bug branch August 23, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants