Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #988 +/- ##
==========================================
+ Coverage 52.54% 53.46% +0.92%
==========================================
Files 20 22 +2
Lines 4345 4962 +617
==========================================
+ Hits 2283 2653 +370
- Misses 2062 2309 +247 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
It looks like it makes sense, @DominikKamp. But how would one test this? It's something that will impact everyone, that's why I'm a bit concerned about sending it untested. |
Contributor
Author
|
It affects Linux and Mac systems where there could be a brewed GMP. So better check this location as well. I have tested the updated branch and the tests seem to pass, otherwise you can just blame it on me. |
Joao-Dionisio
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compilation for SCIP
masteron Mac with Homebrew.