Handle circle artifact server not redirecting to index.html for directories #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
amueller
reviewed
Dec 5, 2016
| @@ -7,6 +7,14 @@ | |||
| if (matches) { | |||
| var ci_id = matches[1]; | |||
| var path = matches[2] || ''; | |||
| if (query.match(/\/$|[^.]{10}$|^[^.]*$/)) { | |||
| // path ends with slash or has no . in last 10 chars => append index.html | |||
There was a problem hiding this comment.
Has no "." in the last 10 chars? What's that for?
There was a problem hiding this comment.
Perhaps I should have made it explicit: to exclude .html, .png, .jpg, .examples, .py, .ipynb, etc.
There was a problem hiding this comment.
ahhh sorry, I'm slow. Maybe add a comment in case I look at it again in a couple of month? ;)
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the previous change,
/circle?1234will get "Artifact not found" due to not showingindex.html