-
Notifications
You must be signed in to change notification settings - Fork 81
Add page to provide CircleCI artifact URL shortener #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there not a risk that the automatic building of the doc erases this file added by hand? I haven't looked in detail but I am guessing that you do something like:
before comitting and pushing the changes. So depending how the copy is done and how "git add everything" is implemented you may delete files that are not in _build/html. |
That doesn't happen. Things are operated on one directory at a time. See On 16 November 2016 at 17:31, Loïc Estève [email protected] wrote:
|
OK, I guess $dir is stable or dev, then LGTM, even better would be to be able to figure out the build number from the PR number. This seems to work for me although you will need to do some post-treatment to find the index.html:
The doc I got this from: |
$dir is a branch name or dev. stable is a symlink. Yes, I was looking for such a way to get back the latest build number. 'tis tempting, however, just to code up the end-to-end business as a On 16 November 2016 at 19:25, Loïc Estève [email protected] wrote:
|
Is there an easy test that this works without merging it? |
Not completely... but any detrimental effect is extremely local! On 17 November 2016 at 08:14, Andreas Mueller [email protected]
|
alright let's try |
This aims to simplify something like scikit-learn/scikit-learn#7855. With this PR, we can go to http://scikit-learn.org/circle?123 to view the documentation from Circle build 123.