Skip to content

Add page to provide CircleCI artifact URL shortener #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2016

Conversation

jnothman
Copy link
Member

@jnothman jnothman commented Nov 16, 2016

This aims to simplify something like scikit-learn/scikit-learn#7855. With this PR, we can go to http://scikit-learn.org/circle?123 to view the documentation from Circle build 123.

@lesteve
Copy link
Member

lesteve commented Nov 16, 2016

Is there not a risk that the automatic building of the doc erases this file added by hand? I haven't looked in detail but I am guessing that you do something like:

cp _build/html/* ~/dev/scikit-learn.github.io
git add everything

before comitting and pushing the changes.

So depending how the copy is done and how "git add everything" is implemented you may delete files that are not in _build/html.

@jnothman
Copy link
Member Author

That doesn't happen. Things are operated on one directory at a time. See
https://github.com/scikit-learn/scikit-learn/blob/master/build_tools/circle/push_doc.sh
.

On 16 November 2016 at 17:31, Loïc Estève [email protected] wrote:

Is there not a risk that the automatic building of the doc erases this
file added by hand? I haven't looked in detail but I am guessing that you
do something like:

cp _build/html/* ~/dev/scikit-learn.github.io
git add everything

before comitting and pushing the changes.

So depending how the copy is done and how "git add everything" is
implemented you may delete files that are not in _build/html.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6zMNmuf26p8ZwzVd-dZ-CZwHQwq3ks5q-qNIgaJpZM4KzTZZ
.

@lesteve
Copy link
Member

lesteve commented Nov 16, 2016

OK, I guess $dir is stable or dev, then LGTM, even better would be to be able to figure out the build number from the PR number. This seems to work for me although you will need to do some post-treatment to find the index.html:

curl 'https://circleci.com/api/v1.1/project/github/scikit-learn/scikit-learn/latest/artifacts?branch=pull/7838'

The doc I got this from:
https://circleci.com/docs/api/#build-artifacts-latest

@jnothman
Copy link
Member Author

$dir is a branch name or dev. stable is a symlink.

Yes, I was looking for such a way to get back the latest build number.
Would be nice to facilitate it more directly, but we can't solve that
through html due to XSS prohibitions.

'tis tempting, however, just to code up the end-to-end business as a
browser extension (which is not bound by XSS rules).

On 16 November 2016 at 19:25, Loïc Estève [email protected] wrote:

OK, I guess $dir is stable or dev, then LGTM, even better would be to be
able to figure out the build number from the PR number. This seems to work
for me although you will need to do some post-treatment to find the
index.html:

curl 'https://circleci.com/api/v1.1/project/github/scikit-learn/scikit-learn/latest/artifacts?branch=pull/7838'


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6y7E3D7BdbMY14Y8buqi9z-qtr7Tks5q-r4KgaJpZM4KzTZZ
.

@amueller
Copy link
Member

Is there an easy test that this works without merging it?

@jnothman
Copy link
Member Author

Not completely... but any detrimental effect is extremely local!

On 17 November 2016 at 08:14, Andreas Mueller [email protected]
wrote:

Is there an easy test that this works without merging it?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#5 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEz6yHX9envOpSkiRxh5v7GThGPOihOks5q-3IrgaJpZM4KzTZZ
.

@amueller
Copy link
Member

alright let's try

@jnothman jnothman merged commit eacaf13 into master Nov 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants