Skip to content

DOC: update stable docs with new mailing list info #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2016
Merged

DOC: update stable docs with new mailing list info #4

merged 1 commit into from
May 24, 2016

Conversation

nelson-liu
Copy link
Contributor

I edited the rst and html files for the 0.17 docs to reflect changes to the mailing list. cc @agramfort

@agramfort
Copy link
Member

LGTM

@amueller @ogrisel ok for you?

@GaelVaroquaux
Copy link
Member

GaelVaroquaux commented May 23, 2016 via email

@nelson-liu
Copy link
Contributor Author

@GaelVaroquaux a patch has been merged in the main repo, but the doc folder there is for the dev documentation, right? It was proposed in scikit-learn/scikit-learn#6812 to update the stable documentation as well.

@amueller
Copy link
Member

I think this is the right thing to do. This is the rendered website, which we want to change. We don't want to have people subscribe to the wrong mailing list until the next release.

LGTM

@jnothman
Copy link
Member

The other way of doing it is backporting the changes to the tagged version
and recompiling... but why bother?

On 24 May 2016 at 11:43, Andreas Mueller [email protected] wrote:

I think this is the right thing to do. This is the rendered website, which
we want to change. We don't want to have people subscribe to the wrong
mailing list until the next release.

LGTM


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#4 (comment)

@amueller
Copy link
Member

the recompiling currently still requires a manual upload, right? Or is building the stable docs also automatic now?

@jnothman
Copy link
Member

Indeed.

On 24 May 2016 at 11:55, Andreas Mueller [email protected] wrote:

the recompiling currently still requires a manual upload, right? Or is
building the stable docs also automatic now?


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#4 (comment)

@jnothman
Copy link
Member

I think we should merge here. LGTM.

@amueller amueller merged commit 66c89b9 into scikit-learn:master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants