Fixed typographical error. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ayushblaze wants to merge 1 commit into scikit-learn:main from ayushblaze:main

ayushblaze commented Jan 27, 2021

combine together to have an full-blown estimator -> # combine together to have a full-blown estimator


          Update plot_svm_anova.rst.txt

4fdd22b

Member

lesteve commented Jan 27, 2021

Thanks for your PR! As noted in the README (https://github.com/scikit-learn/scikit-learn.github.io/blob/main/README.md) please open a similar PR in the scikit-learn/scikit-learn repo: https://github.com/scikit-learn/scikit-learn

Also general comment it is better to create a feature branch to open a PR, creating it from main (or master depending on the convention) is an anti-pattern. For example, see https://blog.jasonmeridth.com/posts/do-not-issue-pull-requests-from-your-master-branch/

Closing this one.

lesteve closed this

Member

lesteve commented Jan 27, 2021

For completeness the problem is indeed in the development version: https://github.com/scikit-learn/scikit-learn/blob/0aee596bb32136df8c68371d696770251c7d14a0/examples/svm/plot_svm_anova.py#L32

Author

ayushblaze commented Jan 27, 2021

Just read the blog, I'll keep this in mind.
Thank you @lesteve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet