Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Update black to 20.8b1 #72

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

TimotheeMathieu
Copy link
Contributor

@TimotheeMathieu TimotheeMathieu commented Oct 12, 2020

Fix of issue #71 .
Only minor changes, should fix CI's.

@TimotheeMathieu
Copy link
Contributor Author

The problem with CI is because black does not work with python 3.6 anymore, from psf/black#1666 we should maybe ask python_requires>=3.6.1

@rth
Copy link
Contributor

rth commented Oct 12, 2020

To fix the CI failure, using a newer Docker image to e.g. circleci/python:3.7.6 would likely help.

@rth
Copy link
Contributor

rth commented Oct 12, 2020

we should maybe ask python_requires>=3.6.1

We can still support 3.6 as a package, but require higher python versions for people contributing. We can indeed probably drop 3.6 soon but for now updating the Docker image version should be enough.

@rth
Copy link
Contributor

rth commented Nov 7, 2020

This fixes the linting in any case. I'll look into other CI issues in a separate PR.

@rth rth changed the title fix black master MAINT Update black to 20.8b1 Nov 7, 2020
@rth rth merged commit 5228f05 into scikit-learn-contrib:master Nov 7, 2020
@TimotheeMathieu TimotheeMathieu deleted the fix_black branch December 21, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants