Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS- New Documentation For scikit-learn-extra #47

Merged
merged 4 commits into from
Mar 19, 2020
Merged

DOCS- New Documentation For scikit-learn-extra #47

merged 4 commits into from
Mar 19, 2020

Conversation

danmurphy1217
Copy link
Contributor

@danmurphy1217 danmurphy1217 commented Feb 21, 2020 •
edited by rth
Loading

Closes #17

adrinjalali
adrinjalali reviewed Feb 24, 2020
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danmurphy1217

@adrinjalali adrinjalali mentioned this pull request Feb 26, 2020
Closed
@chkoar chkoar mentioned this pull request Feb 28, 2020
Closed
2 tasks
chkoar
chkoar reviewed Mar 4, 2020
View reviewed changes
@adrinjalali adrinjalali mentioned this pull request Mar 17, 2020
Closed
adrinjalali
adrinjalali reviewed Mar 17, 2020
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danmurphy1217 you can commit and push to the same branch, and it will show up in the same PR. you don't need to create a new PR.

@danmurphy1217
Copy link
Contributor Author

@danmurphy1217 you can commit and push to the same branch, and it will show up in the same PR. you don't need to create a new PR.

It should be good to go now. Let me know if you have any other questions. Thanks!

adrinjalali
adrinjalali reviewed Mar 18, 2020
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks @danmurphy1217

@danmurphy1217
Copy link
Contributor Author

Otherwise LGTM, thanks @danmurphy1217

@adrinjalali @chkoar, changes have been made.

@adrinjalali adrinjalali merged commit 3852a46 into scikit-learn-contrib:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali left review comments

@chkoar chkoar chkoar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start a developer guide in the docs
3 participants
@danmurphy1217 @adrinjalali @chkoar