Fix Remove bandwidth parameter and add gamma to EigenPro #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamma consistent with the svm scale option.
…'m generating it again to see the difference
|
Thank you for spending your valuable time in catching my mistake @rth. I have implemented all of your suggestions in the latest commit. |
rth
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the gamma and bandwidth parameters were redundant with the eigenpro classifier. This pull request ensures fixes this by only using the one more consistent with sklearn (gamma). To increase consistency with svm, we add the 'scale' parameter to gamma for automatic detection, which chooses gamma in the same way the svm does, using 1/(n_features*X.var()). This pull request closes issue 35.