Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Remove circleci #163

Merged
merged 4 commits into from
Feb 26, 2023

Conversation

TimotheeMathieu
Copy link
Contributor

@TimotheeMathieu TimotheeMathieu commented Feb 26, 2023

This PR removes CircleCI and should use pre-commit.ci instead.

@rth
Copy link
Contributor

rth commented Feb 26, 2023

Thanks! I disabled the circleci building. To fix pre-commit, you need to change the URL in the config file from gitlab to github (same URL otherwise)

@TimotheeMathieu TimotheeMathieu linked an issue Feb 26, 2023 that may be closed by this pull request
Copy link
Contributor

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
If you want to improve linting, I would also recommend replacing flake8 by ruff one day

@TimotheeMathieu
Copy link
Contributor Author

Ok, this looks nice, merging this for now.

@TimotheeMathieu TimotheeMathieu merged commit 5e9e25f into scikit-learn-contrib:main Feb 26, 2023
@TimotheeMathieu TimotheeMathieu deleted the change_ci branch February 26, 2023 08:19
TimotheeMathieu added a commit to TimotheeMathieu/scikit-learn-extra that referenced this pull request Feb 3, 2024
* remove circleci

* update pre-commit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CircleCI fails when merged into main
2 participants