Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT test building wheels #156

Merged
merged 26 commits into from
Mar 27, 2023

Conversation

TimotheeMathieu
Copy link
Contributor

Checking that building wheels for PyPi still works.

@TimotheeMathieu TimotheeMathieu linked an issue Feb 20, 2023 that may be closed by this pull request
@TimotheeMathieu
Copy link
Contributor Author

For whatever reason, 32bit wheel seem to fail upstream with cibuildwheel 2.x even though it worked find with cibuildwheel 1.x. We need cibuildwheel 2.x to have python 3.10 and 3.11 binaries.

For now, I removed the 32bits binaries from the action file and I also removed musllinux that don't work.
I will use the artifacts of cibuildwheel 1.x from before to upload the 32Bit binaries. The consequence is that there is no binary for 32bit python 3.10 and python 3.11.

@TimotheeMathieu
Copy link
Contributor Author

I will also merge this for reference for future release.

@TimotheeMathieu TimotheeMathieu merged commit 627f97b into scikit-learn-contrib:main Mar 27, 2023
@TimotheeMathieu TimotheeMathieu deleted the test_wheels branch March 27, 2023 17:53
TimotheeMathieu added a commit to TimotheeMathieu/scikit-learn-extra that referenced this pull request Feb 3, 2024
* manually trigger build

* comment manual part

* switching to Ubuntu 22.04

* fix bug random test

* black

* fix test ci

* update cibuildwheels

* try another image for manylinux i686

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Skip 3.11 for 32bit

* fix syntax

* remove failing binary

* remove failing binary

* remove all 32 bits

* remove all 32 bits

* remove musllinux

* remove trigger of build wheels

* syntax yml

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v0.3.0
1 participant