Fix compatibility with latest version of scikit-learn #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
Oct 19, 2021
There was a problem hiding this comment.
Thanks @TimotheeMathieu ! Yes, <0.1% coverage change is not a blocker, particularly that sometimes it can be a bit unreliable.
Here however it actually points to a genuine issue, I think, see my comment below.
Also I think this could be the occasion to drop Python 3.6 and sklearn <0.24 support and update the tested versions here by adding 1.0.0 there explicitly in one of the versions.
|
Ok, thanks for catching this. I changed azure pipeline to remove support for python 3.6 and I added a test specific for scikit-learn 1.0.0. |
rth
approved these changes
Oct 19, 2021
Co-authored-by: Roman Yurchak <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of scikit-learn changed squared_loss to squared_error, I fixed this issue in RobustWeightedRegressor
New version of scikit-learn changed check_is_fitted common test that we also use and it failed for fastfood.
There is also a parameter that changed for clustering bandwidth algo, need to be fixed in examples.