Add float32 compatibility to KMedoids #120
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the changes suggested by @rth in PR#83 for dtypes in kmedoids.
In Clara, the dtype changes can make a consequent speedup but for kmedoids, I don't know why but there is no speedup:
Here is a small benchmark :
For Clara we can design settings in which the difference between 64 and 32 bit is quite large. Here I used n_sample = 200 000 in dimension 100 for CLARA and sampling_size = 200 . I used n_sample = 2000 for KMedoids.
Code