-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Warning for Kmedoids with seuclidean
metric
#114
Fix Warning for Kmedoids with seuclidean
metric
#114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TimotheeMathieu ! Could you please also add a test that check that no warning is raised (cf https://stackoverflow.com/a/45671804/1791279) ?
Co-authored-by: Roman Yurchak <[email protected]>
Thanks for the review. I added a test, I used the same test as the one used in the robust module but the idea is the same. |
You can use the "Closes #issue" etc terms (cf https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) to auto-close issues when the PR is merged. |
Hmm, though it was auto-closes even with that phrasing. That's new.. |
In answer to issue #113