Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warning for Kmedoids with seuclidean metric #114

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

TimotheeMathieu
Copy link
Contributor

In answer to issue #113

@TimotheeMathieu TimotheeMathieu linked an issue Apr 21, 2021 that may be closed by this pull request
@TimotheeMathieu TimotheeMathieu requested a review from rth April 21, 2021 11:50
Copy link
Contributor

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TimotheeMathieu ! Could you please also add a test that check that no warning is raised (cf https://stackoverflow.com/a/45671804/1791279) ?

@TimotheeMathieu
Copy link
Contributor Author

Thanks @TimotheeMathieu ! Could you please also add a test that check that no warning is raised (cf https://stackoverflow.com/a/45671804/1791279) ?

Thanks for the review. I added a test, I used the same test as the one used in the robust module but the idea is the same.

@rth rth merged commit 5be10c1 into scikit-learn-contrib:main Apr 21, 2021
@rth
Copy link
Contributor

rth commented Apr 21, 2021

In answer to issue #113

You can use the "Closes #issue" etc terms (cf https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword) to auto-close issues when the PR is merged.

@rth
Copy link
Contributor

rth commented Apr 21, 2021

Hmm, though it was auto-closes even with that phrasing. That's new..

@TimotheeMathieu TimotheeMathieu deleted the KMedoids_seuclidean branch April 21, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in kmedoids.fit when using seuclidian metric
2 participants