Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a developer guide in the docs #17

Closed
adrinjalali opened this issue Jun 6, 2019 · 8 comments · Fixed by #47
Closed

Start a developer guide in the docs #17

adrinjalali opened this issue Jun 6, 2019 · 8 comments · Fixed by #47
Labels
Documentation Documentation related tasks help wanted Extra attention is needed

Comments

@adrinjalali
Copy link
Member

We need to start a developer guide for this repo, and include how users can/should use black to format their code (#15 (comment))

@adrinjalali adrinjalali added help wanted Extra attention is needed Documentation Documentation related tasks labels Jun 6, 2019
@danmurphy1217
Copy link
Contributor

Hi Adrin, is this issue still unsolved? If so, I'm happy to see how I can help.

We need to start a developer guide for this repo, and include how users can/should use black to format their code (#15 (comment))

@adrinjalali
Copy link
Member Author

I don't think it's resolved @danmurphy1217 . Unless @rth has fixed it?

@rth
Copy link
Contributor

rth commented Feb 20, 2020

Please go ahead @danmurphy1217. Thanks! We should try to link to scikit-learn's when possible https://scikit-learn.org/stable/developers/index.html

@danmurphy1217
Copy link
Contributor

Ok, will do. Are there any specific things you'd like me to cover in the documentation other than linking to scikit-learn's site? @rth @adrinjalali Feel free to directly email me @ [email protected] if that is easier. Thanks!

@adrinjalali
Copy link
Member Author

A lot of it would be the same as the one on the main sklearn repo, but certain things can be different.

Regarding communication, we prefer to keep almost everything on the GH issue/PR to keep it open and be inclusive of people who are not necessarily directly involved :)

@danmurphy1217
Copy link
Contributor

Created a pull request, let me know if there's anything else I can do!

@shradhit
Copy link

is the issue closed ? or can i be of any help..

@adrinjalali
Copy link
Member Author

#47 is the one fixing this @shradhit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related tasks help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants