ENH: merge regression_coverage_score and regression_coverage_score_v2 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_score_v2 everywhere except doc examples and notebooks
There was a problem hiding this comment.
Pull Request Overview
This PR merges the usage of two similar functions for computing regression coverage by replacing all calls to regression_coverage_score with regression_coverage_score_v2. It updates tests across multiple files to use the new function and removes an unused import.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mapie_v1/regression.py | Removed an unused import from sklearn.model_selection |
| mapie/tests/test_time_series_regression.py | Replaced regression_coverage_score with regression_coverage_score_v2 in the tests |
| mapie/tests/test_regression.py | Updated tests to use regression_coverage_score_v2 and adjusted function calls accordingly |
| mapie/tests/test_quantile_regression.py | Updated regression coverage function call to the new implementation |
| mapie/tests/test_metrics.py | Removed deprecated tests and updated calls to regression_coverage_score_v2 |
| mapie/metrics/regression.py | Updated documentation and internal calls to align with the new regression_coverage_score_v2 function |
Files not reviewed (1)
- doc/api.rst: Language not supported
Comments suppressed due to low confidence (1)
mapie/tests/test_time_series_regression.py:289
- [nitpick] Consider adding a brief comment to explain why only the first element of regression_coverage_score_v2's returned array is used, to enhance clarity in tests.
coverage = regression_coverage_score_v2(y, y_pis)[0]
…overage_score_v2 in notebooks, fix incorrect imports from previous refactoring
…2 in plot_compare_conformity_scores.py
…2 in plot_prefit.py
…2 in plot_toy_model.py
…2 in plot_ts-tutorial.py
…2 in plot-coverage-width-based-criterion.py
…2 in plot_cqr_symmetry_difference.py
…2 in plot_cqr_tutorial.py
…2 in plot_main-tutorial-regression.py
…2 in plot_nested-cv.py
…2 in plot_timeseries_enbpi.py
…ion/2-advanced-analysis
…2 in 3-scientific-articles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.