improvement: Highlight using directives without double quote #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f522ce to
812efe0
Compare
tgodzik
requested changes
Jul 11, 2023
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| //> using packaging.version "1.0.0" | |||
| //> using scala 2.13 | |||
| //> using dep org.scala-lang::toolkit:0.2.0 | |||
There was a problem hiding this comment.
Could you also add cases like:
using deps org.scala-lang::toolkit:0.2.0,org.scala-lang::toolkit:0.2.1
using numbers 123, 111
using strings "asdf", bfds
There was a problem hiding this comment.
I added more tests. There is still an issue with case like
//> using negative -10
as mentioned here #253, because #constants doesn't include negative numbers, but changing the order of patterns allowed correct highlighting of booleans
Adds support for using directives without `"` like //> using dep some::dependency:1.0.0
812efe0 to
ffeefb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected to VirtusLab/scala-cli#2178
Adds support for using directives without
"like //> using dep some::dependency:1.0.0