Skip to content

Handle names ending with symbolic characters … #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

nicolasstucki
Copy link
Contributor

Fixes #202

@nicolasstucki nicolasstucki marked this pull request as ready for review August 16, 2021 12:27
Copy link
Contributor

@MaximeKjaer MaximeKjaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Should we perhaps rebase to avoid having the onigurama upgrade twice? Or I suppose things will look okay in the merge commit?

@@ -921,7 +921,7 @@ export const scalaTmLanguage: TmLanguage = {
comment: 'For themes: Brackets look nice when colored.'
},
qualifiedClassName: {
match: '(\\b([A-Z][\\w]*))',
match: `(\\b([A-Z][\\w]*)(?:(?<=_)${opchar}+)?)`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could there be multiple _ or is only one allowed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, let's merge then!

@MaximeKjaer MaximeKjaer merged commit 57e0829 into scala:main Aug 20, 2021
@scala scala deleted a comment Sep 16, 2021
@scala scala deleted a comment Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Names end after _ ignoring symbols after the _
2 participants