Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support boolean and numeric values in using directives highlighting #253

Closed
bishabosha opened this issue Apr 12, 2023 · 2 comments
Closed

Comments

@bishabosha
Copy link
Member

bishabosha commented Apr 12, 2023

//> using booleanKeys false, true
//> using numericKey -1

val foo = true
val bar = -1

true and false should also be highlighted the same as in the rhs of foo, currently they highlight like the directive's key. perhaps there is an priority issue because booleans (through #constants) are included in the matched patterns.

Additionally, in -1 the - should be highlighted the same as in the rhs of bar, currently the - is the same colour as the directive's key. This seems to be because the #constants patterns do not include the leading negation sign

@nicolasstucki
Copy link
Contributor

Aren't directives comma-separated strings?

@bishabosha
Copy link
Member Author

I think this issue is resolved now - i.e. the highlighting is now as I expect - everything is a string, except booleans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants