Fix #23113: Treat private classes as sealed #23292
Open
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox213
commented
May 30, 2025
| @@ -1735,7 +1735,7 @@ object SymDenotations { | |||
| c.ensureCompleted() | |||
| end completeChildrenIn | |||
|
|
|||
| if is(Sealed) || isAllOf(JavaEnum) && isClass then | |||
| if (is(Sealed) || is(Private) || isAllOf(JavaEnum)) && isClass then | |||
There was a problem hiding this comment.
The test still passes without this fix, but it seems we should treat private classes as sealed in this case as well.
|
That does not seem right to me. Being private certainly implies being effectively sealed. But full sealed is an intentional decision that impacts pattern match exhaustivity checking. There is no spec basis to make that inference, AFAICT. |
|
#14599 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #23113
Currently, child annotations are only attached when the parent class is sealed. This PR extends that behavior to include private classes as well.