Cache only when the context corresponds to prefix #22982
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e5d2c9 to
44976dc
Compare
|
Flaky cats test. |
44976dc to
9802dd6
Compare
Caching a lookup of c in a.b.c is ok at a.b. A lookup from a.p should not see the cached value.
9802dd6 to
dfc67f5
Compare
|
This deals with the second-hardest problem after naming, but also the performance of the lint requires review, since this is an example of premature caching without benchmarking. It might be preferable to ignore caching (for the sake of correctness) and only then do a review of performance. That also entails a review of architecture and whether mini-phase really serves the use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching a lookup of c in a.b.c is ok at a.b.
A lookup from a.p should not see the cached value.
Fixes #22971