Improve checking LHS of Assign #22977
Draft
+28
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22970
Simple example showing how awkward this is compared to a traversal, where there is more control when descending.
Previously, it "ignored" the LHS of Assign to avoid taking
x = y
as ref tox
instead of assignment to.Now, "mark" the LHS as assignment, so
transformIdent
andSelect
set a "mode" flag, such thatx
is correctly taken as either a ref or assign tox
.Probably there is more complex syntax to handle as LHS, but I haven't had coffee yet.