Test chars safely when highlighting #22918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f80504 to
f553e23
Compare
|
It would be nice if the nuisance message did not make its way into the check file. The test rig could de-duplicate. Again, the goal is that I don't have to change my scala-cli reproduction just to use it as a test. |
f553e23 to
1898a5e
Compare
som-snytt
commented
Apr 23, 2025
| @@ -0,0 +1,5 @@ | |||
| //> using scala 3.7.0-RC1 | |||
| //> using options -rewrite -indent | |||
There was a problem hiding this comment.
This is nominally a no-op without -source 3.0-migration but would throw; it requires the other options to demonstrate the behavior.
There was a problem hiding this comment.
updated to document my comment that vulpix doesn't demonstrate the error.
1898a5e to
0eb77ce
Compare
0eb77ce to
b42e82d
Compare
noti0na1
requested changes
Apr 24, 2025
b42e82d to
d80887d
Compare
The arrow test at lastOffset - 3 is out-of-range when highlighting, which parses a snippet of source. Always check lower bound in testChar. Don't check as initial condition in testChars because it recurses.
d80887d to
3defb6e
Compare
|
Squashed. Some tests such as |
noti0na1
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow test at lastOffset - 3 is out-of-range when highlighting, which parses a snippet of source.
Fixes #22906
Reproduces under scala-cli
-rewrite -indentbut not under vulpix. (It would be nice to know why.) (Needless to add, it shouldn't be a research project to get the test rig to just run a compilation. There is programmatic flag-setting that defies expectations.)This commit also allows a test to
using scalaby ignoring it, as a convenience. When the directive parsing is completely aligned with scala-cli, it should completely ignore what is not supported, so that test files can be used both ways.