Fix orbit conversion for permutation elements #39843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimpase can you please review this, |
|
Documentation preview for this PR (built with commit 7d3c9a9; changes) is ready! 🎉 |
f0d5c32 to
5174084
Compare
|
hello, @roed314, can you run the CI again, had a small doubt, hadn't i force pushed after resolving the merge conflicts, the CI would have to still be ran in that case ?, |
|
The CI is run whenever there's a new version. I'm still seeing issues with 10.6 vs 10.6.rc1 (take a look at the Files Changed tab). |
|
ya, i think something went really wrong during the rebase or something, can you confirm this,: It is showing version 10.6, instead of 10.6rc1, is it right ? |
|
Do this then |
The `input_for_gap` helper function within the `orbit` method failed to convert Sage `PermutationGroupElement` objects when they were present within the structure being acted upon (e.g., a tuple or set passed with `action="OnSets"`). It incorrectly tried to look them up in the base domain map. This commit modifies the base case of `input_for_gap` to check if the element is a `PermutationGroupElement` and, if so, converts it using `libgap()` before passing it to GAP. Added doctest.
5174084 to
4211503
Compare
|
It worked thanks a lot, |
|
@roed314 why is the build doc failing?, |
|
there is a problem in a thematic tutorial in French (you can get the raw log of the CI run and look there) |
|
how to fix that? |
|
you don't have to fix it, it's irrelevant to this PR |
|
i had small doubt, can we get this merged or we'll have to wait till the next release? |
|
Has anyone reviewed the code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
input_for_gaphelper function within theorbitmethod failed to convert SagePermutationGroupElementobjects when they were present within the structure being acted upon (e.g. tuple or set passed withaction="OnSets"). It incorrectly tried to look them up in the base domain map.This modifies the base case of
input_for_gapto check if the element is aPermutationGroupElementand if so, converts it usinglibgap()before passing it to GAP.Added doctest.
Fixes #29151
📝 Checklist
⌛ Dependencies