Implemented ceil/floor methods for QQbar #39822
Open
+93
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dimpase hello, can you please review this |
Added .ceil() and .floor() methods to AlgebraicNumber_base to handle algebraic numbers correctly. This fixes the bug reported in sagemath#39345 where ceil(QQbar(0)) would fail due to reliance on numerical interval arithmetic. The method will prioritize checking for exact integers algebraically before falling back to numerical methods for real, non-integer values. Also raise a TypeError for complex numbers with non-zero imaginary parts, consistent with the standard definition of ceil/floor. Added the doctests.
0b3f9eb to
e8ab8e4
Compare
|
@mezzarobba hello, any feedback on the code and the changes made, |
|
Typically it is vital for performance to handle as many cases as possible using numerical approximations and fall back to exact arithmetic only when necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .ceil() and .floor() methods to AlgebraicNumber_base to handle algebraic numbers correctly.
This fixes the bug reported in #39345 where ceil(QQbar(0)) would fail due to reliance on numerical interval arithmetic.
The method will prioritize checking for exact integers algebraically before falling back to numerical methods for real, non-integer values. Also raise a TypeError for complex numbers with non-zero imaginary parts, consistent with the standard definition of ceil/floor.
Added the doctests.
📝 Checklist
⌛ Dependencies