Skip to content

Rollup of 11 pull requests #85014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
May 7, 2021
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5d9eeff
Ensure TLS destructors run before thread joins in SGX
mzohreva Apr 21, 2021
8a0a4b1
Use atomics in join_orders_after_tls_destructors test
mzohreva Apr 29, 2021
051f9ec
Add --run flag to compiletest
tmandry Apr 24, 2021
0978381
Add run flag to bootstrap test
tmandry Apr 28, 2021
0b2e908
Add support for --run for non-ui tests
tmandry Apr 29, 2021
e282fd0
Include --run in stamp hash
tmandry Apr 29, 2021
f64c45a
Add needs-run-enabled directive for should-fail tests
tmandry Apr 29, 2021
1e46b18
Fix help for profile flags
tmandry Apr 28, 2021
4a63e1e
Allow using `core::` in intra-doc links within core itself
jyn514 Apr 30, 2021
d7cd6e2
Fix RESTRICTED_DEPENDENCY_CRATES to list rustc_driver instead of rust…
bjorn3 May 3, 2021
2fa18b8
Remove obsolete crate exceptions
bjorn3 May 3, 2021
5db01aa
Take build dependencies into account during license checks
bjorn3 May 3, 2021
24def63
Wire up tidy dependency checks for cg_clif
bjorn3 May 3, 2021
6b64202
Handle incorrect placement of parentheses in trait bounds more gracef…
estebank May 4, 2021
0b94338
CTFE engine: rename copy → copy_intrinsic, move to intrinsics.rs
RalfJung May 4, 2021
3584c1d
Disallows `#![feature(no_coverage)]` on stable and beta
richkadel May 3, 2021
ad4ccf9
Remove unneeded call to with_default_session_globals in rustdoc highl…
GuillaumeGomez May 5, 2021
3c489a3
Update highlight tests
GuillaumeGomez May 5, 2021
568d9c5
compiletest: Add --target-panic, needs-unwind
tmandry Apr 29, 2021
e1a8ecf
Add needs-unwind to tests
tmandry Apr 29, 2021
1993e1a
Support multi target-rustcflags for -Zpanic-abort-tests
tmandry Apr 30, 2021
947ad58
Fix up/ignore failing ui tests on fuchsia
tmandry Apr 30, 2021
513c56a
remove unused variant
lcnr May 6, 2021
b981141
outdated comment
lcnr May 6, 2021
2acd62d
join_orders_after_tls_destructors: ensure thread 2 is launched before…
mzohreva May 6, 2021
a7500e5
Add test for suggestion to borrow unsized function parameters
camelid Apr 29, 2021
b30e428
Rollup merge of #84409 - mzohreva:mz/tls-dtors-before-join, r=jethrogb
Dylan-DPC May 6, 2021
dd3747b
Rollup merge of #84500 - tmandry:compiletest-run-flag, r=Mark-Simulacrum
Dylan-DPC May 6, 2021
3a0d6be
Rollup merge of #84728 - camelid:sized-param-sugg-test, r=Mark-Simula…
Dylan-DPC May 6, 2021
577f1d0
Rollup merge of #84734 - tmandry:compiletest-needs-unwind, r=Mark-Sim…
Dylan-DPC May 6, 2021
7835c78
Rollup merge of #84755 - jyn514:core-links, r=kennytm
Dylan-DPC May 6, 2021
aaf2389
Rollup merge of #84871 - richkadel:no-coverage-unstable-only, r=nagisa
Dylan-DPC May 6, 2021
746f97e
Rollup merge of #84872 - bjorn3:cg_clif_tidy, r=Mark-Simulacrum
Dylan-DPC May 6, 2021
b44e56f
Rollup merge of #84896 - estebank:issue-84772, r=jackh726
Dylan-DPC May 6, 2021
eec3ae3
Rollup merge of #84905 - RalfJung:copy, r=oli-obk
Dylan-DPC May 6, 2021
3c5da6e
Rollup merge of #84953 - GuillaumeGomez:remove-unneeded-with_default_…
Dylan-DPC May 6, 2021
01e9d09
Rollup merge of #84987 - lcnr:nits, r=Mark-Simulacrum
Dylan-DPC May 6, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Take build dependencies into account during license checks
The comment says that build dependencies shouldn't matter unless they do
some kind of codegen. It is safer to always check it though.
  • Loading branch information
bjorn3 committed May 3, 2021
commit 5db01aae99a82675565c333ece511daa31d545cb
11 changes: 1 addition & 10 deletions src/tools/tidy/src/deps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -460,16 +460,7 @@ fn normal_deps_of_r<'a>(
.iter()
.find(|n| &n.id == pkg_id)
.unwrap_or_else(|| panic!("could not find `{}` in resolve", pkg_id));
// Don't care about dev-dependencies.
// Build dependencies *shouldn't* matter unless they do some kind of
// codegen. For now we'll assume they don't.
let deps = node.deps.iter().filter(|node_dep| {
node_dep
.dep_kinds
.iter()
.any(|kind_info| kind_info.kind == cargo_metadata::DependencyKind::Normal)
});
for dep in deps {
for dep in &node.deps {
normal_deps_of_r(resolve, &dep.pkg, result);
}
}