-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix --remap-path-prefix
not correctly remapping rust-src
component paths and unify handling of path mapping with virtualized paths
#83813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
65520ec
Add test for --remap-path-prefix on std imports
cbeuw d66506d
Normalise remapped sysroot path as $SRC_DIR
cbeuw 6720a37
Rename RealFileName::Named to LocalPath and Devirtualized to Remapped
cbeuw 9e0426d
Make local_path in RealFileName::Remapped Option to be removed in exp…
cbeuw 0407919
Use RealFileName for Session::working_dir as it may also be remapped
cbeuw e5445f3
Emit RealFileName::Remapped on expanded relative path if working_dir …
cbeuw ec34cd9
Use local name if available in write_out_deps
cbeuw f8e55da
Remove impl Display for FileName and add FileNameDisplay wrapper type
cbeuw fb4f643
Revamp RealFileName public methods
cbeuw 5417b45
Use local and remapped paths where appropriate
cbeuw 0ac9ca4
Add -Z simulate-remapped-rust-src-base option to simulate path viruta…
cbeuw 37dbe86
Split span_to_string into span_to_diagnostic/embeddable_string
cbeuw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add test for --remap-path-prefix on std imports
- Loading branch information
commit 65520ec802f77ab191423f3a1507d6c0be7cfb9c
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
src/test/codegen/remap_path_prefix/issue-73167-remap-std.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// ignore-windows | ||
|
||
// compile-flags: -g -C no-prepopulate-passes --remap-path-prefix=/=/the/root/ | ||
|
||
// Here we check that imported code from std has their path remapped | ||
|
||
// CHECK: !DIFile(filename: "{{/the/root/.*/library/std/src/panic.rs}}" | ||
fn main() { | ||
std::thread::spawn(|| { | ||
println!("hello"); | ||
}); | ||
} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.