Skip to content

always try inlining functions which do not call other functions #77307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

always try inlining functions which do not call other functions #77307

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
152a85f
slightly broken inlining
lcnr Aug 13, 2020
85f5cb4
only encode `is_trivial_mir` if it's true
lcnr Sep 28, 2020
6f9bb55
is_trivial_mir: only consider functions
lcnr Sep 30, 2020
eb900dd
don't arena allocate bools
lcnr Sep 30, 2020
714c06d
cache me on disk
lcnr Oct 17, 2020
c9c966e
allow intrinsics
lcnr Oct 17, 2020
6b17a76
metadata: store `is_trivial_mir` using a `()`
lcnr Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only encode is_trivial_mir if it's true
  • Loading branch information
@lcnr
lcnr committed Oct 20, 2020
commit 85f5cb4765cc11d4837dbc0fe40e98fcbb0ab40e
5 changes: 4 additions & 1 deletion compiler/rustc_metadata/src/rmeta/encoder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,7 +1160,10 @@ impl EncodeContext<'a, 'tcx> {
fn encode_optimized_mir(&mut self, def_id: LocalDefId) {
debug!("EntryBuilder::encode_mir({:?})", def_id);
if self.tcx.mir_keys(LOCAL_CRATE).contains(&def_id) {
record!(self.tables.is_trivial_mir[def_id.to_def_id()] <- self.tcx.is_trivial_mir(def_id));
if self.tcx.is_trivial_mir(def_id) {
record!(self.tables.is_trivial_mir[def_id.to_def_id()] <- true);
}

record!(self.tables.mir[def_id.to_def_id()] <- self.tcx.optimized_mir(def_id));

let unused = self.tcx.unused_generic_params(def_id);
Expand Down