Skip to content

Rollup of 16 pull requests #62192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Jun 28, 2019
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
b66dcb9
explain better that structural pinning is a per-field choice
RalfJung Jun 15, 2019
c489636
mention that overwrite-without-drop also violates the drop guarantee,…
RalfJung Jun 15, 2019
665aa3e
minor edits
RalfJung Jun 15, 2019
86e283a
keep links in local crate where possible
RalfJung Jun 16, 2019
2eb074d
make example code typecheck at least
RalfJung Jun 16, 2019
f250951
Apply suggestions from code review
RalfJung Jun 19, 2019
bf03a3c
nits
RalfJung Jun 19, 2019
a99a7b7
Remove FnBox.
Centril Jun 22, 2019
1c12b1b
call out explicitly that general read needs to be called with an init…
RalfJung Jun 24, 2019
b75021b
refactor lexer to use idiomatic borrowing
matklad Jun 25, 2019
0f34d7a
Updated RELEASES.md for 1.36.0
XAMPPRocky Jun 23, 2019
ba12e78
Add more tests for async/await
cramertj Jun 25, 2019
57db25e
cleanup: rename name_from to symbol_from
matklad Jun 25, 2019
390f717
tweak wording
RalfJung Jun 25, 2019
dedcd97
Use f{32,64}::from_bits
Xanewok Jun 25, 2019
12806b7
Fix clippy::redundant_field_names
Xanewok Jun 25, 2019
6c93b47
Fix clippy::cast_losless
Xanewok Jun 26, 2019
33f58ba
Fix clippy::redundant_closure
Xanewok Jun 26, 2019
1af1f62
Fix clippy::print_with_newline
Xanewok Jun 26, 2019
ad62b42
Fix clippy::precedence
Xanewok Jun 26, 2019
5cb841d
Don't ICE on item in `.await` expression
cofibrant Jun 26, 2019
182ce77
remove old fixme
mark-i-m Jun 26, 2019
72ca844
Add regression test for MIR drop generation in async loops
cramertj Jun 26, 2019
7e62050
Update books
ehuss Jun 26, 2019
e053eed
Remove outdated question_mark_macro_sep lint
ia0 Jun 26, 2019
768d500
save-analysis: use buffered writes
jsgf Jun 27, 2019
b608749
rustc: Retry SIGILL linker invocations
alexcrichton Jun 27, 2019
d79104b
Update RLS
Xanewok Jun 27, 2019
8819420
Add suggestion for missing `.await` keyword
cofibrant Jun 19, 2019
7ddfae7
Rollup merge of #61878 - RalfJung:pin, r=Dylan-DPC
Centril Jun 27, 2019
2f6cf36
Rollup merge of #62043 - Centril:remove-fnbox, r=cramertj
Centril Jun 27, 2019
df97fc6
Rollup merge of #62067 - doctorn:await_diagnostic, r=matthewjasper
Centril Jun 27, 2019
1c7d311
Rollup merge of #62076 - XAMPPRocky:master, r=XAMPPRocky
Centril Jun 27, 2019
36b26e9
Rollup merge of #62102 - RalfJung:read, r=Centril
Centril Jun 27, 2019
e8f3986
Rollup merge of #62106 - cramertj:test-await, r=centril
Centril Jun 27, 2019
bc335d6
Rollup merge of #62124 - matklad:without-with, r=petrochenkov
Centril Jun 27, 2019
4aa3e27
Rollup merge of #62131 - Xanewok:clip-some-nits, r=petrochenkov
Centril Jun 27, 2019
274c3de
Rollup merge of #62152 - doctorn:async_let_ice, r=cramertj
Centril Jun 27, 2019
0fe028e
Rollup merge of #62154 - mark-i-m:old-fixme, r=Centril
Centril Jun 27, 2019
a1a0e0c
Rollup merge of #62155 - cramertj:61872, r=centril
Centril Jun 27, 2019
766795f
Rollup merge of #62156 - ehuss:update-books, r=ehuss
Centril Jun 27, 2019
fdf75af
Rollup merge of #62160 - ia0:question_mark_macro_sep, r=petrochenkov
Centril Jun 27, 2019
dec2c8b
Rollup merge of #62164 - jsgf:buffer-save-analysis, r=Xanewok
Centril Jun 27, 2019
d6fd059
Rollup merge of #62171 - alexcrichton:more-restarts, r=eddyb
Centril Jun 27, 2019
65f1ff4
Rollup merge of #62176 - Xanewok:update-rls, r=alexcrichton
Centril Jun 27, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
  • Loading branch information
RalfJung and Centril authored Jun 19, 2019
commit f25095170251c102c32f6bb0705d1feabbd6fe04
8 changes: 4 additions & 4 deletions src/libcore/pin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@
//! }
//! }
//! ```
//! `inner_drop` has the type that `drop` *should* have, so this makes sure that
//! The function `inner_drop` has the type that `drop` *should* have, so this makes sure that
//! you do not accidentally use `self`/`this` in a way that is in conflict with pinning.
//!
//! Moreover, if your type is `#[repr(packed)]`, the compiler will automatically
Expand All @@ -196,7 +196,7 @@
//! The usual approach is to write helper methods (so called *projections*)
//! that turn `Pin<&mut Struct>` into a reference to the field, but what
//! type should that reference have? Is it `Pin<&mut Field>` or `&mut Field`?
//! The same question arises with the fields of an enum, and also when considering
//! The same question arises with the fields of an `enum`, and also when considering
//! container/wrapper types such as [`Vec<T>`], [`Box<T>`], or [`RefCell<T>`].
//! (This question applies to both mutable and shared references, we just
//! use the more common case of mutable references here for illustration.)
Expand All @@ -209,7 +209,7 @@
//! pinning removed as part of the projection. If both are done for the same field,
//! that will likely be unsound!
//!
//! Basically, as the author of a data structure you get to decide for each field whether pinning
//! As the author of a data structure you get to decide for each field whether pinning
//! "propagates" to this field or not. Pinning that propagates is also called "structural",
//! because it follows the structure of the type.
//! In the following, we describe the considerations that have to be made for either choice.
Expand All @@ -235,7 +235,7 @@
//! ```
//!
//! You may also `impl Unpin for Struct` *even if* the type of `field`
//! is not `Unpin`. What that type thinks about pinning is just not relevant
//! is not `Unpin`. What that type thinks about pinning is not relevant
//! when no `Pin<&mut Field>` is ever created.
//!
//! ## Pinning *is* structural for `field`
Expand Down