THIR pattern building: Pass HIR nodes instead of loose types/spans #150660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in match checking cc @Nadrieril |
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
This should make it easier to keep track of where the types/spans came from.
davidtwco
approved these changes
Jan 4, 2026
Member
|
@bors r+ rollup |
Collaborator
bors
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 12, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
In the future I would also like to make more of these lowering methods return
Box<thir::Pat>instead ofthir::PatKind, so that it becomes feasible to add more fields tothir::Pat(e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.