Skip to content

rustdoc search: increase strictness of typechecking #137981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 5, 2025
Merged

rustdoc search: increase strictness of typechecking #137981

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a8c0b3b
rustdoc search: increase strictness of typechecking
lolbinarycat Mar 4, 2025
2f9ea8a
rustdoc search: give buildTypeMapIndex a conditional return type
lolbinarycat Mar 4, 2025
60c5855
ParserQueryElement.typeFilter MAY be a string, OR number.
lolbinarycat Mar 4, 2025
7635f2b
fix whitespace
lolbinarycat Mar 4, 2025
32ebe8e
don't use double quotes
lolbinarycat Mar 4, 2025
d130e25
search.js: local variable `extra` is an array, annotate it as such.
lolbinarycat Mar 4, 2025
78b92f0
search.js: second argument of convertNameToId is optional
lolbinarycat Mar 4, 2025
9581f19
search.js: give pathSplitter a type signature
lolbinarycat Mar 4, 2025
4f6772d
give local mgens a type
lolbinarycat Mar 4, 2025
c05f6bf
search.js: give local `where` a type
lolbinarycat Mar 4, 2025
374de12
search.js: give buildIndex a proper return type
lolbinarycat Mar 4, 2025
5f39026
search.js: allow empty result arrays
lolbinarycat Mar 4, 2025
a9a52dd
search.js: give RawSearchIndexCrate.a an index signature
lolbinarycat Mar 4, 2025
8920167
search.js: remove incorrect outdated comment
lolbinarycat Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
give local mgens a type
  • Loading branch information
@lolbinarycat
lolbinarycat committed Mar 4, 2025
commit 4f6772d2ac31cdf5ca4fb0b3087a0d884a1f2c5c
3 changes: 1 addition & 2 deletions src/librustdoc/html/static/js/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2834,7 +2834,7 @@ class DocSearch {
}
let fnInputs = null;
let fnOutput = null;
// @ts-expect-error
/** @type {Map<number, number> | null} */
let mgens = null;
if (typeInfo !== "elems" && typeInfo !== "returned") {
fnInputs = unifyFunctionTypes(
Expand Down Expand Up @@ -3047,7 +3047,6 @@ class DocSearch {
writeFn(nested, result);
}
return;
// @ts-expect-error
} else if (mgens) {
for (const [queryId, fnId] of mgens) {
if (fnId === fnType.id) {
Expand Down
Loading