Skip to content

Rollup of 12 pull requests #122444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 44 commits into from
Closed
Changes from 2 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
f1d594e
Add `-Z external-clangrt`
chriswailes Feb 16, 2024
bf62d59
Give `TRACK_DIAGNOSTIC` a return value.
nnethercote Feb 9, 2024
ecd3718
Inline and remove `Level::get_diagnostic_id`.
nnethercote Feb 13, 2024
272e60b
Move `DelayedBug` handling into the `match`.
nnethercote Feb 13, 2024
c81767e
Reorder `has_future_breakage` handling.
nnethercote Feb 13, 2024
aec4bdb
Move `Expect`/`ForceWarning` handling into the `match`.
nnethercote Feb 13, 2024
a7d9262
Add comments about `TRACK_DIAGNOSTIC` use.
nnethercote Feb 13, 2024
7ef605b
Make the `match` in `emit_diagnostic` complete.
nnethercote Mar 1, 2024
15b71f4
Add CStr::bytes iterator
clarfonthey Nov 13, 2022
a38a556
Reduce unsafe code, use more NonNull APIs per @cuviper review
clarfonthey Mar 12, 2024
f2fcfe8
Various style improvements to `rustc_lint::levels`
Zalathar Mar 13, 2024
8f21da1
compiletest: Allow `only-unix` in test headers
Enselic Mar 11, 2024
ee8efd7
fix: typos
testwill Mar 13, 2024
cdeeed8
Increase timeout for new bors bot
Kobzol Mar 13, 2024
e0488c0
Fix StableMIR is_full computation
celinval Mar 13, 2024
90acda1
Fix accidental re-addition of removed code in a previous PR
oli-obk Mar 13, 2024
f10ebfe
Generalize `eval_in_interpreter` with a helper trait
oli-obk Mar 11, 2024
44b1f8a
Move only usage of `take_static_root_alloc` to its definition and inl…
oli-obk Mar 11, 2024
31fa142
Move error handling into const_validate_mplace
oli-obk Mar 11, 2024
71ef9e2
Move InterpCx into eval_in_interpreter
oli-obk Mar 11, 2024
bd7580b
Move generate_stacktrace_from_stack away from InterpCx to avoid havin…
oli-obk Mar 11, 2024
7aee665
Directly pass in the stack instead of computing it from a machine
oli-obk Mar 11, 2024
ffaf082
Remove an argument that can be computed cheaply
oli-obk Mar 12, 2024
66a46bb
Share the `InterpCx` creation between static and const evaluation
oli-obk Mar 12, 2024
af59eec
Move validation into eval_body_using_ecx
oli-obk Mar 12, 2024
2a1a6fa
Move the entire success path into `eval_body_using_ecx`
oli-obk Mar 12, 2024
d919b04
Generate link to `Local` in `hir::Let` documentation
GuillaumeGomez Mar 13, 2024
3393227
Rename some things around validation error reporting to signal that i…
oli-obk Mar 13, 2024
cb15bf6
Rename `ValidityConstraint` -> `PlaceValidity`
Nadrieril Mar 13, 2024
4fc35c4
Rename `TypeCx` -> `PatCx`
Nadrieril Mar 13, 2024
f275406
Rename `RustcMatchCheckCtxt` -> `RustcPatCtxt`
Nadrieril Mar 13, 2024
c423678
Remove `MaybeInfiniteInt::JustAfterMax`
Nadrieril Mar 13, 2024
a50f490
Rollup merge of #104353 - clarfonthey:cstr-bytes-iter, r=cuviper
matthiaskrgr Mar 13, 2024
6423b56
Rollup merge of #120699 - nnethercote:rm-useless-TRACK_DIAGNOSTIC-cal…
matthiaskrgr Mar 13, 2024
1891141
Rollup merge of #121207 - chriswailes:z-external-clangrt, r=michaelwo…
matthiaskrgr Mar 13, 2024
ded786f
Rollup merge of #122397 - oli-obk:machine-read-hook2, r=RalfJung
matthiaskrgr Mar 13, 2024
490d2c7
Rollup merge of #122416 - Zalathar:levels, r=petrochenkov
matthiaskrgr Mar 13, 2024
39e8cf2
Rollup merge of #122422 - Enselic:only-unix, r=oli-obk
matthiaskrgr Mar 13, 2024
d7c3262
Rollup merge of #122424 - testwill:typos, r=michaelwoerister
matthiaskrgr Mar 13, 2024
d228c0c
Rollup merge of #122425 - Kobzol:new-bors-update-timeout, r=lqd
matthiaskrgr Mar 13, 2024
50c35ce
Rollup merge of #122426 - celinval:smir-fix-full, r=oli-obk
matthiaskrgr Mar 13, 2024
229bb51
Rollup merge of #122430 - GuillaumeGomez:link-to-local, r=TaKO8Ki
matthiaskrgr Mar 13, 2024
d55d257
Rollup merge of #122434 - Nadrieril:renames, r=compiler-errors
matthiaskrgr Mar 13, 2024
49f0d18
Rollup merge of #122437 - Nadrieril:no-after-max, r=compiler-errors
matthiaskrgr Mar 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions compiler/rustc_hir/src/hir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1253,11 +1253,11 @@ pub struct Arm<'hir> {
pub body: &'hir Expr<'hir>,
}

/// Represents a `let <pat>[: <ty>] = <expr>` expression (not a Local), occurring in an `if-let` or
/// `let-else`, evaluating to a boolean. Typically the pattern is refutable.
/// Represents a `let <pat>[: <ty>] = <expr>` expression (not a [`Local`]), occurring in an `if-let`
/// or `let-else`, evaluating to a boolean. Typically the pattern is refutable.
///
/// In an if-let, imagine it as `if (let <pat> = <expr>) { ... }`; in a let-else, it is part of the
/// desugaring to if-let. Only let-else supports the type annotation at present.
/// In an `if let`, imagine it as `if (let <pat> = <expr>) { ... }`; in a let-else, it is part of
/// the desugaring to if-let. Only let-else supports the type annotation at present.
#[derive(Debug, Clone, Copy, HashStable_Generic)]
pub struct Let<'hir> {
pub span: Span,
Expand Down