Skip to content

Allow Vec::leak when using no_global_oom_handling #103153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

Allow Vec::leak when using no_global_oom_handling #103153

merged 1 commit into from
Oct 19, 2022

Conversation

ChrisDenton
Copy link
Member

As the documentation notes, Vec::leak hasn't allocated since 1.57.

cc @Ericson2314 in case I'm missing something.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 17, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2022
@ChrisDenton ChrisDenton mentioned this pull request Oct 17, 2022
Closed
@m-ou-se
Copy link
Member

m-ou-se commented Oct 18, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2022

📌 Commit 913393a has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Oct 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2022
@bors
Auto merge of rust-lang#103228 - Dylan-DPC:rollup-31yiauw, r=Dylan-DPC
d7dd01f 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#102863 (Standardize "use parentheses to call" suggestions between typeck and trait selection)
 - rust-lang#103034 (Let expressions on RHS shouldn't be terminating scopes)
 - rust-lang#103127 (Make transpose const and inline)
 - rust-lang#103153 (Allow `Vec::leak` when using `no_global_oom_handling`)
 - rust-lang#103182 (Clean up query descriptions)
 - rust-lang#103216 (Consider patterns in fn params in an `Elided(Infer)` lifetime rib.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d056ea8 into rust-lang:master Oct 19, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 19, 2022
@ChrisDenton ChrisDenton deleted the leak-oom branch October 19, 2022 14:17
@Ericson2314
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ChrisDenton @rustbot @rust-highfive @m-ou-se @bors @Ericson2314 @joshtriplett