Skip to content

Fix set-contains-or-insert FP when set is mutated before insert #16009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samueltardieu merged 1 commit into from
Dec 15, 2025
Merged

Fix set-contains-or-insert FP when set is mutated before insert #16009

samueltardieu merged 1 commit into from
Dec 15, 2025
+49 −4

Conversation

@profetia
Copy link
Member

@profetia profetia commented Nov 2, 2025 •
edited by rustbot
Loading

Closes #15990

changelog: [set-contains-or-insert] fix FP when set is mutated before insert

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ada4a
ada4a suggested changes Nov 8, 2025
View reviewed changes
@profetia
Copy link
Member Author

profetia commented Nov 25, 2025

r? clippy

@rustbot rustbot assigned samueltardieu and unassigned Jarcho Nov 25, 2025
samueltardieu
samueltardieu requested changes Nov 26, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 27, 2025
samueltardieu
samueltardieu requested changes Nov 27, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't you add the new tests I showed in this comment?

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 27, 2025
@profetia
Copy link
Member Author

profetia commented Nov 29, 2025

Sorry I must have forgotten (´･ω･`). I've added them now

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Nov 29, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Dec 15, 2025
Merged via the queue into rust-lang:master with commit 099062d Dec 15, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

+1 more reviewer

@ada4a ada4a ada4a requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fp: set-contains-or-insert where set is mutated between contains and insert

5 participants

@profetia @rustbot @samueltardieu @ada4a @Jarcho