Skip to content

Conversation

@ShoyuVanilla
Copy link
Member

Fixes #21255

Hopefully this is the last thing that messes up our sysroot metadata fetch 😅

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2025
@ChayimFriedman2
Copy link
Contributor

Shouldn't we run it inside the current directory then? What does Cargo do?

@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Dec 15, 2025

Cargo doesn't fetch metadata for sysroot, only we do.
Once we tried to fetch sysroot metadata within the cwd but it resulted in applying some not-wanted configs to sysroot metadata like in #20250
I'm not sure which one is grater, the number of configs should applied to sysroot likewise in the project cwd, or the number of configs that shouldn't applied to the sysroot. But for something like the above issue, there aren't much thing the user can do to avoid the issue, so I chose not running cargo metadata for sysroot in cwd.

Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, reasonable then.

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Dec 15, 2025
Merged via the queue into rust-lang:master with commit ccb1138 Dec 15, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2025
@ShoyuVanilla ShoyuVanilla deleted the sysroot-target branch December 15, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom target json not found after toolchain update

3 participants