Fix for issue 1808

[marcdejonge]

It turned out that the split_at_position_complete for str returned the beginning of the string with length 0, instead of the end. This broke the offset calculations.

Fixes #1808

[codspeed-hq]

CodSpeed Performance Report

Merging #1811 will improve performances by ×3.7

_{Comparing marcdejonge:issue-1808 (42ef74d) with main (a44b52e)}

Summary

⚡ 22 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
⚡	arithmetic	4.3 µs	2.9 µs	+51.02%
⚡	parse[291]	8.5 µs	7.6 µs	+11.98%
⚡	parse_streaming[291]	8.8 µs	7.7 µs	+14.72%
⚡	parse[110]	7.4 µs	6.1 µs	+22.53%
⚡	parse[18]	1,127.5 ns	833.3 ns	+35.3%
⚡	parse[45]	2.5 µs	1.9 µs	+37.39%
⚡	parse[109]	9.1 µs	6.7 µs	+36.18%
⚡	json canada	80.6 ms	70.1 ms	+14.95%
⚡	float bytes	1.9 µs	1.2 µs	+65.02%
⚡	float str	1.7 µs	1.5 µs	+11.05%
⚡	json	23.3 µs	20.5 µs	+13.39%
⚡	json	21.3 µs	18.5 µs	+14.86%
⚡	recognize float bytes	728.6 ns	232.8 ns	×3.1
⚡	std_float bytes	1.8 µs	1.1 µs	+61.43%
⚡	json canada verbose	97.8 ms	84 ms	+16.32%
⚡	json verbose	27.8 µs	24.4 µs	+14.17%
⚡	float bytes streaming	748.6 ns	482.5 ns	+55.15%
⚡	float str streaming	2.6 µs	1.6 µs	+65.41%
⚡	json streaming	23.5 µs	18 µs	+30.87%
⚡	recognize float bytes streaming	688.6 ns	188.6 ns	×3.7
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[Geal]

nice catch, thanks

[mcheshkov]

@Geal could you please make a crates.io release with this fix?